Arrow

typo/error in standings.php file | Peter's Sports League Standings | Forum

Back to the sports standings script page

Please consider registering
guest

Log In

Lost password?
Advanced Search

— Forum Scope —

  

— Match —

   

— Forum Options —

   

Minimum search word length is 4 characters - maximum search word length is 84 characters

Topic RSS
typo/error in standings.php file
September 19, 2008
6:04 pm
Jon
Guest

I think there is an error on your line #351 in standings.php file.

Where you show all past scores, you have:
option value=”0”>All teams

I changed to:
option value=”all”>All teams

Also as a suggestion, I further modified the lines above that to say:

[h2>[a name=”past” target=”_blank”>Past Scores

[form name="”teamsort”" method="”post”" action="”#past”">

GREAT SCRIPT!!!!

September 21, 2008
5:16 pm
Peter
Admin
Forum Posts: 841
Offline

Thanks for the suggestions. I will add these tweaks to the code base for the next version.

September 21, 2008
8:41 pm
Jason
Guest

What do these changes do?

September 21, 2008
8:59 pm
Peter
Admin
Forum Posts: 841
Offline

This first change was a minor fix due to a typo. The main display decides whether or not to filter the schedules by team based on what’s posted to it. It ignores filtering if the relevant value is “all”. Otherwise, it filters the schedule based on the posted team ID. Of course, no team has an ID of 0 (which is what the typo specified), so the end result has no actual change in functionality.

The second change makes it so that when the filter form is submitted, the page will jump down to the schedule (instead of just loading the page and remaining at the top). The first part of that change creates the anchor tag and the second part appends the anchor to the destination URL of that form. So the end result there is a small but handy user experience improvement.

September 21, 2008
10:52 pm
Jason
Guest

Thanks for the info.